Handle a special case of borrowed from instruction in CopyToBorrowOptimization #80733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
force-pushed
the
updatectb
branch
2 times, most recently
from
51ca3c5 to
f161a08
Compare
|
@swift-ci test |
|
@swift-ci test |
eeckstein
reviewed
Apr 11, 2025
| @@ -360,6 +360,14 @@ private extension Value { | |||
| } | |||
|
|
|||
| var lookThroughForwardingInstructions: Value { | |||
| if let bfi = definingInstruction as? BorrowedFromInst, | |||
| let forwardedOp = bfi.singleForwardedOperand, | |||
| let phi = Phi(forwardedOp.value), !phi.isReborrow, | |||
There was a problem hiding this comment.
you can just use bfi.borrowedPhi instead of getting it through the singleForwardedOperand
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
CopyToBorrowOptimization, acopy_valuewith aguaranteedoperand can be optimized away if all uses ofcopy_valuecan be replaced by theguaranteedoperand and if theguaranteedoperand's scope outlives thecopy_valueliveness.For this, it uses
lookThroughForwardingInstructions. Until now, forborrowed frominstructions this utility returned itssingleForwardedOperandwhich is aphiand not handled inisFullyContainedIn.If the
borrowed frominstruction has a single enclosing value, we can return this instead enabling more optimizations if it turns out to be handled byisFullyContainedIn.