Skip to content

[Concurrency] Offer way to get SerialExecutor from Actor #81063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 24, 2025

This allows to access the isIsolatingCurrentContext when all we have in hand is an Actor.

SE proposal update is over here: swiftlang/swift-evolution#2801

@ktoso
Copy link
Contributor Author

ktoso commented Apr 24, 2025

@swift-ci please smoke test

@ktoso ktoso requested review from al45tair and Copilot April 24, 2025 03:24
Copilot

This comment was marked as resolved.

@ktoso
Copy link
Contributor Author

ktoso commented Apr 24, 2025

Heh added the copilot to codereview by accident...

@ktoso ktoso requested review from DougGregor and hborla April 24, 2025 03:26
@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Apr 24, 2025
@ktoso
Copy link
Contributor Author

ktoso commented Apr 24, 2025

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-actor.withSerialExecutor branch from 017c6b7 to bf8e592 Compare April 25, 2025 00:55
@ktoso ktoso force-pushed the wip-actor.withSerialExecutor branch from bf8e592 to d94164c Compare April 25, 2025 00:56
@ktoso
Copy link
Contributor Author

ktoso commented Apr 25, 2025

@swift-ci please smoke test

1 similar comment
@ktoso
Copy link
Contributor Author

ktoso commented Apr 25, 2025

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 25, 2025

Confused why the autocompletion tests fail on CI but pass locally hmm...

@ktoso ktoso force-pushed the wip-actor.withSerialExecutor branch from ecdedab to 7112f7e Compare April 25, 2025 09:46
@ktoso
Copy link
Contributor Author

ktoso commented Apr 25, 2025

@swift-ci please smoke test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@DougGregor DougGregor merged commit 7cfc1b9 into swiftlang:main Apr 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants