[6.2] RemoteInspection: Support for parameter packs #81379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
adrian-prantl
approved these changes
May 8, 2025
| Fn handleComponent) { | ||
| // Substitute the shape using the baseline substitutions, not the | ||
| // current elementwise projections. | ||
| auto *substShape = origExpansion->getCount()->subst(Builder, Substitutions); |
There was a problem hiding this comment.
Can this fail; do we need to nullptr-check the result of GetCount()?
There was a problem hiding this comment.
We assume throughout that the components of a TypeRef are themselves not null. This is an invariant at construction time. If we decide to add null checks, they would have to be scattered throughout the code on every call to a get*() method on TypeRef. I'd rather not do that.
|
|
||
| auto *substPackShape = dyn_cast<PackTypeRef>(substShape); | ||
| if (!substPackShape) { | ||
| DEBUG_LOG(fprintf(stderr, "Replacement for pack must be another pack")); |
There was a problem hiding this comment.
[We really should upgrade this library to llvm::Expected<> at some point]
slavapestov
force-pushed
the
remote-mirrors-meet-packs-6.2
branch
from
3263d13 to
8744493
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry-pick of #81299.
Description: Remote mirrors did not support types containing parameter packs. Add that support.
Scope of the issue: This meant that parameter packs defeat lldb's remote mirrors-based code path, forcing the ASTContext to be loaded. This should no longer be necessary.
Risk: There is a bunch of new code, and it might have bugs in it. However this doesn't change behavior of existing code.
Reviewed by: @adrian-prantl