[Caching] Remove CASFS based clang module implementation #81494
Merged
+115
−439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
xymus,
artemcm,
tshortli,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
|
@swift-ci please smoke test |
Remove the CASFS based clang module implemenation as it is not longer used.
After removing the CASFS implementation for clang modules, there is no need to capture clang extra file that sets up the VFS for the clang modules since all content imported by ClangImporter is dependency scanned and available via include-tree. This saves more ClangImporter instance when caching is enabled. Update the test to check that clang content found via `-Xcc` VFS options can currently work without capture the headermaps and vfs overlays.
cachemeifyoucan
force-pushed
the
eng/PR-remove-clang-module-cas-fs
branch
from
e860dc9 to
1506a0d
Compare
|
@swift-ci please smoke test |
artemcm
approved these changes
May 14, 2025
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…R-remove-clang-module-cas-fs" This reverts commit f2ef2d3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove CASFS-based clang module caching build. This code path is not maintained and it adds overhead for maintaining the code path without any testing outside the unit tests.
This also allows us remove some code path that is only used by CASFS implementation and get some performance benefits. This includes removing the extra ClangImporter construction needed when caching is used.
rdar://151339073