Skip to content

Update collections, crypto, certs, and asn1 tag #82583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Update collections, crypto, certs, and asn1 tag #82583

merged 2 commits into from
Jul 10, 2025

Conversation

etcwilde
Copy link
Member

Updating tags for swift-collections, swift-crypto, swift-certificates, and swift-asn1 to pick up changes needed for FreeBSD.

@etcwilde etcwilde requested a review from shahmishal as a code owner June 27, 2025 21:41
@etcwilde etcwilde added the FreeBSD Platform: FreeBSD label Jun 27, 2025
@etcwilde
Copy link
Member Author

@swift-ci please test

@etcwilde
Copy link
Member Author

@swift-ci please test Linux

@etcwilde
Copy link
Member Author

@swift-ci please test Windows

@etcwilde etcwilde force-pushed the ewilde/update-dep-versions branch from 2333668 to 0a4b6e5 Compare July 2, 2025 23:25
@etcwilde
Copy link
Member Author

etcwilde commented Jul 2, 2025

@swift-ci please test

@etcwilde etcwilde moved this to In Progress in Swift on FreeBSD Jul 2, 2025
@etcwilde
Copy link
Member Author

etcwilde commented Jul 3, 2025

swiftlang/sourcekit-lsp#2194
@swift-ci please test Windows

shahmishal
shahmishal reviewed Jul 3, 2025
View reviewed changes
@etcwilde
Update collections, crypto, certs, and asn1 tag
e9d42a4 
Updating tags for swift-collections, swift-crypto, swift-certificates,
and swift-asn1 to pick up changes needed for FreeBSD.
@etcwilde etcwilde force-pushed the ewilde/update-dep-versions branch from 0a4b6e5 to e9d42a4 Compare July 6, 2025 17:21
@etcwilde etcwilde requested a review from shahmishal July 6, 2025 17:22
@etcwilde
Copy link
Member Author

etcwilde commented Jul 6, 2025

@swift-ci please test

@etcwilde
Copy link
Member Author

etcwilde commented Jul 7, 2025

error WIX0103: Cannot find the File file 'T:\\Program Files\\Swift\\Platforms\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\windows\_FoundationCollections.swiftmodule\aarch64.swiftdoc'

I need to update the swift installer scripts repo with the new module layout.

@etcwilde
Copy link
Member Author

etcwilde commented Jul 7, 2025

swiftlang/swift-installer-scripts#434
@swift-ci please test Windows

@etcwilde
Copy link
Member Author

etcwilde commented Jul 7, 2025

@swift-ci please test macOS

@etcwilde
Copy link
Member Author

etcwilde commented Jul 7, 2025

swiftlang/swift-installer-scripts#434
@swift-ci please test Windows

@etcwilde
build.ps1: Update reference to CCryptoBoringSSL
2ff24aa 
The CCryptoBoringSSL library changed from C to C++, which means that the
static archive on Windows changed names, from `CCryptoBoringSSL.lib` to
`libCCryptoBoringSSL.lib`. The SourceKit-LSP SwiftPM test invocation
explicitly passed `CCryptoBoringSSL.lib` to the SwiftPM invocation,
resulting in the wrong search path. Pointing it at the correct location
now.
@etcwilde etcwilde requested a review from compnerd as a code owner July 8, 2025 18:12
@etcwilde
Copy link
Member Author

etcwilde commented Jul 8, 2025

@swift-ci please test

@etcwilde
Copy link
Member Author

etcwilde commented Jul 8, 2025

swiftlang/swift-installer-scripts#434
@swift-ci please test Windows

1 similar comment
@etcwilde
Copy link
Member Author

etcwilde commented Jul 8, 2025

swiftlang/swift-installer-scripts#434
@swift-ci please test Windows

@etcwilde
Copy link
Member Author

etcwilde commented Jul 8, 2025

@swift-ci please test Linux

1 similar comment
@etcwilde
Copy link
Member Author

etcwilde commented Jul 9, 2025

@swift-ci please test Linux

@etcwilde etcwilde self-assigned this Jul 9, 2025
@etcwilde etcwilde merged commit ef9e714 into swiftlang:main Jul 10, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Swift on FreeBSD Jul 10, 2025
@etcwilde etcwilde mentioned this pull request Aug 2, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edymtt edymtt edymtt approved these changes

@justice-adams-apple justice-adams-apple justice-adams-apple approved these changes

@CodingCarpincho CodingCarpincho CodingCarpincho approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@compnerd compnerd Awaiting requested review from compnerd compnerd is a code owner

Assignees

@etcwilde etcwilde

Labels
FreeBSD Platform: FreeBSD
Projects
Swift on FreeBSD
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@etcwilde @edymtt @shahmishal @justice-adams-apple @CodingCarpincho