[cxx-interop] Add source location to instantiation error #82717
Merged
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the diagnostic was emitted with an unknown location.
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar and
susmonteiro
as code owners
Xazax-hun
requested review from
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Jul 2, 2025
hnrklssn
reviewed
Jul 2, 2025
| @@ -25,12 +25,12 @@ public protocol A { } | |||
| public protocol B { } | |||
| public protocol C { } | |||
|
|
|||
| // CHECK: error: unexpected error produced: could not generate C++ types from the generic Swift types provided; the following Swift type(s) provided to 'passThrough' could not be converted: any A & B | |||
| // CHECK: function-templates.h{{.*}}: error: diagnostic produced elsewhere: could not generate C++ types from the generic Swift types provided; the following Swift type(s) provided to 'passThrough' could not be converted: any A & B | |||
There was a problem hiding this comment.
You should be able to match the line number with [[@LINE+1]]
There was a problem hiding this comment.
This location is in a header that we import, so the line reported here has no relationship to the lines in this file. Or is there a way to make that work regardless?
There was a problem hiding this comment.
Oh year, right! It could be done by putting the CHECK line in the header, and passing the header to FileCheck instead. But that may or may not be suitable here.
|
@swift-ci please smoke test Windows |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the diagnostic was emitted with an unknown location.