[cxx-interop] Test std::optional with AddressableParameters
#82809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
egorzhdan
force-pushed
the
egorzhdan/optional-pointee-fix
branch
from
1d1b8d1 to
ae95986
Compare
egorzhdan
force-pushed
the
egorzhdan/optional-pointee-fix
branch
from
ae95986 to
fce8cce
Compare
|
@swift-ci please test |
egorzhdan
force-pushed
the
egorzhdan/optional-pointee-fix
branch
from
fce8cce to
660b4b8
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
egorzhdan
force-pushed
the
egorzhdan/optional-pointee-fix
branch
from
660b4b8 to
99ac064
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Enabling AddressableParameters feature resolves a miscompile with `var pointee` properties of `std::optional`. rdar://154945438 / #82765
egorzhdan
force-pushed
the
egorzhdan/optional-pointee-fix
branch
from
99ac064 to
bec3ba9
Compare
|
@swift-ci please smoke test Linux |
egorzhdan
force-pushed
the
egorzhdan/optional-pointee-fix
branch
from
bec3ba9 to
00ed3bd
Compare
|
@swift-ci please test |
egorzhdan
requested review from
Xazax-hun,
fahadnayyar,
hnrklssn,
j-hui,
susmonteiro and
zoecarver
as code owners
hnrklssn
approved these changes
Sep 10, 2025
Xazax-hun
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see each commit for details.
This relies on #82879.