[stdlib] Handle arguments with alignment larger than a word in KeyPath #83161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azoy
force-pushed
the
keypath-overaligned-arguments
branch
from
54faa4a to
b8d3d03
Compare
|
@swift-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Azoy
force-pushed
the
keypath-overaligned-arguments
branch
from
896093a to
9c3c4e6
Compare
|
@swift-ci please test |
Add test for overaligned keypath arguments
Azoy
force-pushed
the
keypath-overaligned-arguments
branch
from
0e15206 to
1071451
Compare
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
@swift-ci please test macOS |
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing arguments to a key path subscript component, we put the arguments into pointer aligned memory. This is a problem when the argument itself has an alignment larger than the platform's pointer alignment. We may end up magically putting on correctly aligned memory, but in most cases we won't. Handle this issue here by putting down padding for these over aligned arguments and recording the amount of padding and what alignment the argument is. Types in Swift are guaranteed to have lower than 16 byte alignment on all current platforms, so 64 bit platforms only need to worry about the 16 byte case whereas 32 bit needs to handle 8 byte and 16 byte aligned arguments.
Resolves: rdar://155108633