Skip to content

[cxx-interop] Fix name mangling for reference types #83176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2025
Merged

[cxx-interop] Fix name mangling for reference types #83176

merged 1 commit into from
Jul 19, 2025

Conversation

Xazax-hun
Copy link
Contributor

Fixes #83097

rdar://155973210

@Xazax-hun Xazax-hun added the c++ interop Feature: Interoperability with C++ label Jul 18, 2025
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

j-hui
j-hui approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@j-hui j-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I have one question: do you need account for const refs and volatile refs here, or is that information attached to the pointee type?

@Xazax-hun
Copy link
Contributor Author

const refs and volatile refs here, or is that information attached to the pointee type

Yup, those should be on the pointee type.

egorzhdan
egorzhdan approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test macOS

@mrousavy
Copy link

wow! crazy - nice work 👏

@Xazax-hun Xazax-hun merged commit f40d3b4 into swiftlang:main Jul 19, 2025
3 checks passed
@mrousavy mrousavy mentioned this pull request Jul 21, 2025
Closed
5 tasks
Xazax-hun added a commit to Xazax-hun/swift that referenced this pull request Aug 13, 2025
@Xazax-hun
[6.2][cxx-interop] Fix name mangling for reference types
f974dba 
Explanation: When generating type names for template instantiations for
name mangling we did not generate correct names for reference types
resulting in collisions in the mangled names.
Issues: rdar://157237301
Original PRs: swiftlang#83176
Risk: Low, the generated string is only used for name mangling.
Testing: Added a compiler test.
Reviewers: @egorzhdan
@Xazax-hun Xazax-hun mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@j-hui j-hui j-hui approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro is a code owner

@hnrklssn hnrklssn Awaiting requested review from hnrklssn hnrklssn is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When calling a Swift function that takes two std::functions with const-reference types as arguments, the Swift compiler crashes
4 participants
@Xazax-hun @mrousavy @egorzhdan @j-hui