[Concurrency] InferSendableFromCaptures: Rework check to delay lookup #83210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the check accounts only for the overload choices present in the initial lookup but for some situations, like bridged or optional base types, `performMemberLookup` uses a secondary lookup as well, results of which are ignored. Let's fold the check into `addChoice` instead and set the the flag there to make sure that all of the choices are considered. Resolves: rdar://143586718
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
hamishknight
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the check accounts only for the overload choices present in the initial lookup but for some situations, like bridged or optional base types,
performMemberLookupuses a secondary lookup as well, results of which are ignored.Let's fold the check into
addChoiceinstead and set the the flag there to make sure that all of the choices are considered.Resolves: rdar://143586718