Revert "Set the Compilation directory when generating the Skeleton CU" #83304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b286b1c. Reverted because fix for rdar://131726681 broke rdar://154247270 Reverting and will try to fix properly later
|
@swift-ci please test |
adrian-prantl
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b286b1c.
Reverted because fix for #74870, with change mentioned above modified the DW_AT_comp_dir for skeleton CUs of PCHs to be incorrect and set to the path that was passed in with the option -file-compilation-dir instead of the actual PCH path passed in via -import-objc-header
Reverting and will try to fix properly later