Supplemental: Android fixes for the Supplemental Runtimes #83382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup the interface include directory that seems to not be setup implicitly by CMake as it should be. This workaround is necessary to ensure that we are able to build against this module.
Clean up whitespace to match style.
This fixes up the Android builds to properly link against the right modules. With this we properly propagate the necessary flags to build the runtimes without colliding with existing builds.
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects two issues in the runtimes build which are preventative towards use of the builds:
swiftAndroidmodule to get the Swift overlay rather than just the clang module.Together, these changes enable building the C++ Interop libraries for Android with the new support.