Skip to content

New SIL Loop Invariant Code Motion pass #83512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 46 commits into from
Closed

New SIL Loop Invariant Code Motion pass #83512

wants to merge 46 commits into from

Conversation

MAJKFL
Copy link
Contributor

@MAJKFL MAJKFL commented Aug 4, 2025

This PR introduces a new SIL loop Invariant Code Motion (licm) pass rewritten in Swift. The goal of the new implementation is to:

  • Migrate the pass to Swift
  • Simplify and unify the algorithm implementation
  • Explore previously missed optimization opportunities (such as e.g. speculatively hoisting tuple_element_addr and struct_element_addr instructions)
  • Enable support for values with ownership

MAJKFL added 26 commits July 15, 2025 11:51
@MAJKFL
Add initial structure for the new licm pass.
2a305e1
@MAJKFL
Complete instruction extraction in analyzeLoop. Add more filtering af…
e2ada85 
…ter extraction.
@MAJKFL
Implement the remainder of besides .
23a0026
@MAJKFL
Implement the remainder of .
2f8a0cd
@MAJKFL
Add sinking and hoisting instructions.
9a3b85c
@MAJKFL
Format.
27db055
@MAJKFL
Add traversal of dom children.
ea81e32
@MAJKFL
Minor bug fixes.
45a02a6
@MAJKFL
Minor bug fixes.
95b89ce
@MAJKFL
Add generalized cloner. Add initial implementation of .
12ae07b
@MAJKFL
Add . Minor fixes.
d9f59c2
@MAJKFL
Fix SSA updater not introducing phi nodes in hoistLoadsAndStores.
dce2b7c
@MAJKFL
Fix loop re-running for some transformation. Fix copying for values w…
b2acc8a 
…ith e.g. function arguments as a base.
@MAJKFL
Add recursive load spliting.
13d9b1e
@MAJKFL
Add trySplit along an access path. Other minor fixes.
fdccfca
@MAJKFL
Refactor loop analysis.
153df29
@MAJKFL
Restructure licm algorithm into extensions.
cf5b9b8
@MAJKFL
Add removal of duplicates when hoisting instructions. Removes the nec…
cf13e6f 
…essity of running cse sometimes after the pass.
@MAJKFL
Add simple hoist.
5438deb
@MAJKFL
Fix end access hoisting by checking whether instructions are inside t…
bb5fdcb 
…he scope.
@MAJKFL
Fix side effect handling. Reintroduce non-standard projection test case.
11f1e77
@MAJKFL
Merge branch 'main'
d92a2cc 
#Conflicts:
#	SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ClosureSpecialization.swift
#	SwiftCompilerSources/Sources/Optimizer/PassManager/Context.swift
#	SwiftCompilerSources/Sources/Optimizer/Utilities/CMakeLists.txt
#	SwiftCompilerSources/Sources/SIL/BasicBlock.swift
#	include/swift/SILOptimizer/OptimizerBridging.h
#	include/swift/SILOptimizer/OptimizerBridgingImpl.h
#	lib/SILOptimizer/Utils/OptimizerBridging.cpp
@MAJKFL
Fix merge artifacts.
1a7bf6d
@MAJKFL
Fix build artifacts related to the new Cloner.
cd4bcdf
@MAJKFL
Enable new licm in pass pipeline.
f974cc3
@MAJKFL
Revert back deleted vim files.
2db5711
eeckstein
eeckstein reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first batch of comments

eeckstein
eeckstein reviewed Aug 5, 2025
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the next set of comments

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ClosureSpecialization.swift
/// "derivative" of the original function.
///
/// VJPs always return a tuple of 2 values -- the original result and the Pullback. Pullbacks are essentially a chain
/// "derivative" of the original function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the formatting changes in this file are not intended.

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 13, 2025

@swift-ci apple silicon benchmark

1 similar comment
@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 14, 2025

@swift-ci apple silicon benchmark

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 15, 2025

@swift-ci Please smoke test

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 15, 2025

@swift-ci Please smoke test Linux Platform

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 18, 2025

@swift-ci Please smoke test

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 18, 2025

@swift-ci apple silicon benchmark

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 18, 2025

@swift-ci Please Test Source Compatibility Release

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 18, 2025

@swift-ci Please test

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 19, 2025

@swift-ci Please smoke test

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 20, 2025

@swift-ci Please smoke test

eeckstein
eeckstein reviewed Aug 21, 2025
View reviewed changes
eeckstein
eeckstein reviewed Aug 22, 2025
View reviewed changes
MAJKFL added 3 commits August 27, 2025 13:17
@MAJKFL
Move remaining comments from the old to new implementation. Refactor.
15e9365
@MAJKFL
Merge branch 'main' into new-sil-licm-pass
b8b6b48 
# Conflicts:
#	SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ClosureSpecialization.swift
@MAJKFL
Fix merge artifacts.
7e27996
@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 27, 2025

@swift-ci Please smoke test

eeckstein
eeckstein reviewed Aug 28, 2025
View reviewed changes
@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 28, 2025

@swift-ci Please smoke test

@MAJKFL
Copy link
Contributor Author

MAJKFL commented Aug 28, 2025

@swift-ci Please smoke test

@MAJKFL MAJKFL mentioned this pull request Aug 28, 2025
Merged
@MAJKFL MAJKFL closed this Sep 1, 2025
@AnthonyLatsis
Copy link
Collaborator

Superseded by #83988.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein left review comments

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver will be requested when the pull request is marked ready for review zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan will be requested when the pull request is marked ready for review egorzhdan is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun will be requested when the pull request is marked ready for review Xazax-hun is a code owner

@j-hui j-hui Awaiting requested review from j-hui j-hui will be requested when the pull request is marked ready for review j-hui is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar will be requested when the pull request is marked ready for review fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro will be requested when the pull request is marked ready for review susmonteiro is a code owner

@hnrklssn hnrklssn Awaiting requested review from hnrklssn hnrklssn will be requested when the pull request is marked ready for review hnrklssn is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter will be requested when the pull request is marked ready for review jckarter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MAJKFL @AnthonyLatsis @eeckstein