Skip to content

[concurrency] Cleanup verify-additional-prefix usage in tests. #83647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

This includes a bunch of fixes. It is not exhaustive but fit my time boxed time period I set aside to look at this today.

A quick non-exhaustive list:

  1. I removed unnecessary verify-additional-prefix lines.
  2. Split tests with typechecker error and non-typechecker error components.
  3. Removed complete- lines that we used when testing w/without send non sednable.
  4. Translated complete-and-tns- lines to be just complete- since they are just testing strict-concurrency=complete and we are not testing complete without send non sendable anymore.

@gottesmm gottesmm requested a review from ktoso as a code owner August 11, 2025 20:14
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

This includes a bunch of fixes. It is not exhaustive but fit my time boxed time
period I set aside to look at this today.

A quick non-exhaustive list:

1. I removed unnecessary verify-additional-prefix lines.
2. Split tests with typechecker error and non-typechecker error components.
3. Removed complete- lines that we used when testing w/without send
non sednable.
4. Translated complete-and-tns- lines to be just complete- since they are just
testing strict-concurrency=complete and we are not testing complete without
send non sendable anymore.
@gottesmm gottesmm force-pushed the pr-8bc8f006238466ee540d773a626ed76edf069d55 branch from dc158e0 to df2844d Compare August 12, 2025 17:56
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm enabled auto-merge August 12, 2025 17:57
@gottesmm
Copy link
Contributor Author

@swift-ci test windows platform

@gottesmm gottesmm merged commit e33e824 into swiftlang:main Aug 13, 2025
3 checks passed
@gottesmm gottesmm deleted the pr-8bc8f006238466ee540d773a626ed76edf069d55 branch August 13, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants