[cxx-interop] Properly support OS objects in reverse interop #83670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These objects are behind typedefs and user code supposed to use the typedef names. We already have some logic in place for Obj-C interop. Reuse the same logic for C++ to use the correct names. rdar://150453489
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro and
hnrklssn
as code owners
j-hui
approved these changes
Aug 12, 2025
|
@swift-ci please smoke test |
Yup, that would be amazing. Maybe an annotation describing the preferred typedef to be used when a type is referenced in the reverse interop header? |
egorzhdan
approved these changes
Aug 13, 2025
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These objects are behind typedefs and user code supposed to use the typedef names. We already have some logic in place for Obj-C interop. Reuse the same logic for C++ to use the correct names.
rdar://150453489