Skip to content

[test][abi] Fix unusual off-by-one backreference issue in arm64 ABI list #83679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

[test][abi] Fix unusual off-by-one backreference issue in arm64 ABI list #83679

merged 1 commit into from
Aug 14, 2025

Conversation

lorentey
Copy link
Member

#83314 landed with a fix for the same issue on Intel, but the arm64 variant of the same bug has slipped through.

rdar://158099889

@lorentey lorentey requested a review from a team as a code owner August 12, 2025 20:24
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey enabled auto-merge August 12, 2025 20:25
@lorentey
Copy link
Member Author 

[2025-08-13T00:27:32.838Z] FAIL: Swift(watchsimulator-x86_64) :: PrintAsObjC/unicode-scalar-reference.swift (6368 of 19762)
[2025-08-13T00:27:32.838Z] ******************** TEST 'Swift(watchsimulator-x86_64) :: PrintAsObjC/unicode-scalar-reference.swift' FAILED ********************
[2025-08-13T00:27:32.838Z] Exit Code: 1
[2025-08-13T00:27:32.838Z] 
[2025-08-13T00:27:32.838Z] Command Output (stderr):
[2025-08-13T00:27:32.838Z] --
[2025-08-13T00:27:32.838Z] RUN: at line 1: rm -rf "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-watchsimulator-x86_64/PrintAsObjC/Output/unicode-scalar-reference.swift.tmp" && mkdir -p "/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-watchsimulator-x86_64/PrintAsObjC/Output/unicode-scalar-reference.swift.tmp"
[2025-08-13T00:27:32.838Z] + rm -rf /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-watchsimulator-x86_64/PrintAsObjC/Output/unicode-scalar-reference.swift.tmp
[2025-08-13T00:27:32.838Z] + mkdir -p /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-watchsimulator-x86_64/PrintAsObjC/Output/unicode-scalar-reference.swift.tmp
[2025-08-13T00:27:32.838Z] RUN: at line 7: /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/bin/swift-frontend -target x86_64-apple-watchos6.0-simulator  -module-cache-path /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/swift-test-results/x86_64-apple-watchos6.0-simulator/clang-module-cache -sdk '/Applications/Xcode.app/Contents/Developer/Platforms/WatchSimulator.platform/Developer/SDKs/WatchSimulator11.2.sdk' -swift-version 4  -define-availability 'SwiftStdlib 9999:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999' -define-availability 'StdlibDeploymentTarget 9999:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999' -define-availability 'SwiftStdlib 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2' -define-availability 'StdlibDeploymentTarget 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2' -define-availability 'SwiftStdlib 5.1:macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0' -define-availability 'StdlibDeploymentTarget 5.1:macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0' -define-availability 'SwiftStdlib 5.2:macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4' -define-availability 'StdlibDeploymentTarget 5.2:macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4' -define-availability 'SwiftStdlib 5.3:macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0' -define-availability 'StdlibDeploymentTarget 5.3:macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0' -define-availability 'SwiftStdlib 5.4:macOS 11.3, iOS 14.5, watchOS 7.4, tvOS 14.5' -define-availability 'StdlibDeploymentTarget 5.4:macOS 11.3, iOS 14.5, watchOS 7.4, tvOS 14.5' -define-availability 'SwiftStdlib 5.5:macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0' -define-availability 'StdlibDeploymentTarget 5.5:macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0' -define-availability 'SwiftStdlib 5.6:macOS 12.3, iOS 15.4, watchOS 8.5, tvOS 15.4' -define-availability 'StdlibDeploymentTarget 5.6:macOS 12.3, iOS 15.4, watchOS 8.5, tvOS 15.4' -define-availability 'SwiftStdlib 5.7:macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0' -define-availability 'StdlibDeploymentTarget 5.7:macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0' -define-availability 'SwiftStdlib 5.8:macOS 13.3, iOS 16.4, watchOS 9.4, tvOS 16.4' -define-availability 'StdlibDeploymentTarget 5.8:macOS 13.3, iOS 16.4, watchOS 9.4, tvOS 16.4' -define-availability 'SwiftStdlib 5.9:macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0' -define-availability 'StdlibDeploymentTarget 5.9:macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0' -define-availability 'SwiftStdlib 5.10:macOS 14.4, iOS 17.4, watchOS 10.4, tvOS 17.4, visionOS 1.1' -define-availability 'StdlibDeploymentTarget 5.10:macOS 14.4, iOS 17.4, watchOS 10.4, tvOS 17.4, visionOS 1.1' -define-availability 'SwiftStdlib 6.0:macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0' -define-availability 'StdlibDeploymentTarget 6.0:macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0' -define-availability 'SwiftStdlib 6.1:macOS 15.4, iOS 18.4, watchOS 11.4, tvOS 18.4, visionOS 2.4' -define-availability 'StdlibDeploymentTarget 6.1:macOS 15.4, iOS 18.4, watchOS 11.4, tvOS 18.4, visionOS 2.4' -define-availability 'SwiftStdlib 6.2:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, visionOS 9999' -define-availability 'StdlibDeploymentTarget 6.2:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, visionOS 9999' -define-availability 'SwiftStdlib 6.3:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, visionOS 9999' -define-availability 'StdlibDeploymentTarget 6.3:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, visionOS 9999' -define-availability 'SwiftCompatibilitySpan 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2, visionOS 1.0' -define-availability 'SwiftCompatibilitySpan 6.2:macOS 26.0, iOS 26.0, watchOS 26.0, tvOS 26.0, visionOS 26.0'  -typo-correction-limit 10   -enable-source-import -sdk '/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/Inputs/clang-importer-sdk' -I '/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/Inputs/clang-importer-sdk/swift-modules'      /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/PrintAsObjC/unicode-scalar-reference.swift -emit-module -verify -o /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-watchsimulator-x86_64/PrintAsObjC/Output/unicode-scalar-reference.swift.tmp -emit-module-doc    -emit-clang-header-path /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-watchsimulator-x86_64/PrintAsObjC/Output/unicode-scalar-reference.swift.tmp/compat.h
[2025-08-13T00:27:32.838Z] + /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/bin/swift-frontend -target x86_64-apple-watchos6.0-simulator -module-cache-path /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/swift-test-results/x86_64-apple-watchos6.0-simulator/clang-module-cache -sdk /Applications/Xcode.app/Contents/Developer/Platforms/WatchSimulator.platform/Developer/SDKs/WatchSimulator11.2.sdk -swift-version 4 -define-availability 'SwiftStdlib 9999:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999' -define-availability 'StdlibDeploymentTarget 9999:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999' -define-availability 'SwiftStdlib 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2' -define-availability 'StdlibDeploymentTarget 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2' -define-availability 'SwiftStdlib 5.1:macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0' -define-availability 'StdlibDeploymentTarget 5.1:macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0' -define-availability 'SwiftStdlib 5.2:macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4' -define-availability 'StdlibDeploymentTarget 5.2:macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4' -define-availability 'SwiftStdlib 5.3:macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0' -define-availability 'StdlibDeploymentTarget 5.3:macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0' -define-availability 'SwiftStdlib 5.4:macOS 11.3, iOS 14.5, watchOS 7.4, tvOS 14.5' -define-availability 'StdlibDeploymentTarget 5.4:macOS 11.3, iOS 14.5, watchOS 7.4, tvOS 14.5' -define-availability 'SwiftStdlib 5.5:macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0' -define-availability 'StdlibDeploymentTarget 5.5:macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0' -define-availability 'SwiftStdlib 5.6:macOS 12.3, iOS 15.4, watchOS 8.5, tvOS 15.4' -define-availability 'StdlibDeploymentTarget 5.6:macOS 12.3, iOS 15.4, watchOS 8.5, tvOS 15.4' -define-availability 'SwiftStdlib 5.7:macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0' -define-availability 'StdlibDeploymentTarget 5.7:macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0' -define-availability 'SwiftStdlib 5.8:macOS 13.3, iOS 16.4, watchOS 9.4, tvOS 16.4' -define-availability 'StdlibDeploymentTarget 5.8:macOS 13.3, iOS 16.4, watchOS 9.4, tvOS 16.4' -define-availability 'SwiftStdlib 5.9:macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0' -define-availability 'StdlibDeploymentTarget 5.9:macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0' -define-availability 'SwiftStdlib 5.10:macOS 14.4, iOS 17.4, watchOS 10.4, tvOS 17.4, visionOS 1.1' -define-availability 'StdlibDeploymentTarget 5.10:macOS 14.4, iOS 17.4, watchOS 10.4, tvOS 17.4, visionOS 1.1' -define-availability 'SwiftStdlib 6.0:macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0' -define-availability 'StdlibDeploymentTarget 6.0:macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0' -define-availability 'SwiftStdlib 6.1:macOS 15.4, iOS 18.4, watchOS 11.4, tvOS 18.4, visionOS 2.4' -define-availability 'StdlibDeploymentTarget 6.1:macOS 15.4, iOS 18.4, watchOS 11.4, tvOS 18.4, visionOS 2.4' -define-availability 'SwiftStdlib 6.2:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, visionOS 9999' -define-availability 'StdlibDeploymentTarget 6.2:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, visionOS 9999' -define-availability 'SwiftStdlib 6.3:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, visionOS 9999' -define-availability 'StdlibDeploymentTarget 6.3:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, visionOS 9999' -define-availability 'SwiftCompatibilitySpan 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2, visionOS 1.0' -define-availability 'SwiftCompatibilitySpan 6.2:macOS 26.0, iOS 26.0, watchOS 26.0, tvOS 26.0, visionOS 26.0' -typo-correction-limit 10 -enable-source-import -sdk /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/Inputs/clang-importer-sdk -I /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/Inputs/clang-importer-sdk/swift-modules /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/PrintAsObjC/unicode-scalar-reference.swift -emit-module -verify -o /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-watchsimulator-x86_64/PrintAsObjC/Output/unicode-scalar-reference.swift.tmp -emit-module-doc -emit-clang-header-path /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-watchsimulator-x86_64/PrintAsObjC/Output/unicode-scalar-reference.swift.tmp/compat.h
[2025-08-13T00:27:32.838Z] /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/PrintAsObjC/unicode-scalar-reference.swift:23:10: error: unexpected note produced: add '@available' attribute to enclosing global function
[2025-08-13T00:27:32.838Z]     func y_referencesFloat16(a: Float16, b: CFloat16) { }
[2025-08-13T00:27:32.838Z]          ^
[2025-08-13T00:27:32.838Z] /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/PrintAsObjC/unicode-scalar-reference.swift:23:10: error: unexpected note produced: add '@available' attribute to enclosing global function
[2025-08-13T00:27:32.838Z]     func y_referencesFloat16(a: Float16, b: CFloat16) { }
[2025-08-13T00:27:32.838Z]          ^
[2025-08-13T00:27:32.838Z] /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/PrintAsObjC/unicode-scalar-reference.swift:23:33: error: unexpected error produced: 'Float16' is only available in watchOS 7.0 or newer
[2025-08-13T00:27:32.838Z]     func y_referencesFloat16(a: Float16, b: CFloat16) { }
[2025-08-13T00:27:32.838Z]                                 ^
[2025-08-13T00:27:32.838Z] /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/test/PrintAsObjC/unicode-scalar-reference.swift:23:45: error: unexpected error produced: 'CFloat16' is only available in watchOS 7.0 or newer
[2025-08-13T00:27:32.838Z]     func y_referencesFloat16(a: Float16, b: CFloat16) { }
[2025-08-13T00:27:32.838Z]                                             ^
[2025-08-13T00:27:32.838Z] 
[2025-08-13T00:27:32.838Z] --
[2025-08-13T00:27:32.838Z] 
[2025-08-13T00:27:32.838Z] ********************

@lorentey
Copy link
Member Author

@swift-ci smoke test macOS platform

@lorentey lorentey merged commit 24ac33d into swiftlang:main Aug 14, 2025
4 of 5 checks passed
@lorentey lorentey deleted the fix-arm64-abi-list branch August 14, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glessard glessard glessard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentey @glessard