Skip to content

Synchronization: repair the build on Windows i686 #83732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

compnerd
Copy link
Member

Ensure that we always enable -whole-module-optimization as otherwise we see library calls (e.g. __atomic_load) rather than the expected inlined operation.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

@swift-ci please smoke test

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty disgusting... Please file an issue to remove once we have the new driver at least, and please wrap the -wmo in a check for CMP0157 so that we don't accidentally generate the wrong build graph.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd compnerd requested a review from etcwilde August 15, 2025 20:00
Ensure that we always enable `-whole-module-optimization` as otherwise
we see library calls (e.g. `__atomic_load`) rather than the expected
inlined operation.
@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member Author

@swift-ci please smoke test macOS platform

@compnerd compnerd merged commit b1c8382 into swiftlang:main Aug 18, 2025
3 checks passed
@compnerd compnerd deleted the sychronize branch August 18, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants