[cxx-interop] Allow many specializations of a class template #83751
+6
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
hnrklssn
approved these changes
Aug 15, 2025
Xazax-hun
approved these changes
Aug 15, 2025
|
@swift-ci please smoke test Linux |
|
@swift-ci please test Windows |
j-hui
approved these changes
Aug 15, 2025
egorzhdan
force-pushed
the
egorzhdan/many-specializations
branch
from
14cee28 to
d23f790
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
egorzhdan
force-pushed
the
egorzhdan/many-specializations
branch
from
d23f790 to
85041e4
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/many-specializations
branch
from
85041e4 to
56970f9
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/many-specializations
branch
from
56970f9 to
56ad74b
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
An old piece of logic in ClangImporter was trying to limit the number of instantiations for each C++ class template to prevent long compile times. Unfortunately this started causing hard-to-reproduce deserialization errors on large projects which use many different instantiations of `std::vector` and `std::allocator`. The instantiation limit was arbitrary, it serves no real purpose and causes issues. This change removes it. rdar://158397914
egorzhdan
force-pushed
the
egorzhdan/many-specializations
branch
from
56ad74b to
fed7373
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An old piece of logic in ClangImporter was trying to limit the number of instantiations for each C++ class template to prevent long compile times. Unfortunately this started causing hard-to-reproduce deserialization errors on large projects which use many different instantiations of
std::vectorandstd::allocator.The instantiation limit was arbitrary, it serves no real purpose and causes issues. This change removes it.
rdar://158397914