[cxx-interop] Allow retain/release operations to return an unsigned integer #83753
+47
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
force-pushed
the
egorzhdan/retain-release-unsigned
branch
from
729cde3 to
30f0ad8
Compare
|
@swift-ci please smoke test |
egorzhdan
requested review from
zoecarver,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
Xazax-hun
approved these changes
Aug 15, 2025
Xazax-hun
reviewed
Aug 15, 2025
…nteger Release/retain functions for C++ foreign reference types might return a reference count as an integer value. Swift previously emitted an error for such functions, saying that the retain/release functions need to return void or a reference to the value. rdar://157853183
egorzhdan
force-pushed
the
egorzhdan/retain-release-unsigned
branch
from
30f0ad8 to
3887ed0
Compare
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Aug 15, 2025
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release/retain functions for C++ foreign reference types might return a reference count as an integer value.
Swift previously emitted an error for such functions, saying that the retain/release functions need to return void or a reference to the value.
rdar://157853183