[Diags] Allow multiple in-flight diagnostics #83776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
AnthonyLatsis,
hborla,
slavapestov,
xedin and
xymus
as code owners
The ASTPrinter may kick requests that may emit diagnostics, make sure we don't attempt to recursively print the decl since that would lead to infinite recursion when diagnosing the cycle.
Lift the limitation of a single active diagnostic, which was a pretty easy-to-hit footgun. We now maintain an array of active in-flight diagnostics, which gets flushed once all them have ended.
hamishknight
force-pushed
the
the-diags-never-stop-no
branch
from
29c9d83 to
89feb8f
Compare
|
@swift-ci please test |
xedin
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lift the limitation of a single active diagnostic, which was a pretty easy-to-hit footgun. We now maintain an array of active in-flight diagnostics, which gets flushed once all them have ended.