Remove diag::type_of_expression_is_ambiguous
#83803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov,
xedin,
AnthonyLatsis,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn and
ktoso
as code owners
hamishknight
commented
Aug 19, 2025
| ERROR(type_of_expression_is_ambiguous,none, | ||
| "type of expression is ambiguous without a type annotation", ()) | ||
|
|
||
| ERROR(failed_to_produce_diagnostic,Fatal, |
There was a problem hiding this comment.
Not actually sure if we want to keep this as a fatal error given we'll now be emitting it in more cases, thoughts?
There was a problem hiding this comment.
Updated to make non-fatal 👍
hamishknight
force-pushed
the
err-fallback
branch
from
3cb3d94 to
db33599
Compare
This is a diagnostic that is only really emitted as a fallback when the constraint system isn't able to better diagnose the expression. It's not particulary helpful for the user, and can be often be misleading since the underlying issue might not actually be an ambiguity, and the user may well already have a type annotation. Let's instead just emit the fallback diagnostic that we emit in all other cases, asking the user to file a bug.
hamishknight
force-pushed
the
err-fallback
branch
from
db33599 to
5c3f670
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a diagnostic that is only really emitted as a fallback when the constraint system isn't able to better diagnose the expression. It's not particularly helpful for the user, and can be often be misleading since the underlying issue might not actually be an ambiguity, and the user may well already have a type annotation. Let's instead just emit the fallback diagnostic that we emit in all other cases, asking the user to file a bug.