AST: Continue process of removing replaceCovariantResultType() #83858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
covariant-result-type-part-2
branch
2 times, most recently
from
8a431d9 to
8504689
Compare
… to simplifyAppliedOverloadsImpl()
slavapestov
changed the title
slavapestov
force-pushed
the
covariant-result-type-part-2
branch
from
8504689 to
a7d12e7
Compare
slavapestov
requested review from
AnthonyLatsis,
Xazax-hun,
bnbarham,
egorzhdan,
fahadnayyar,
hamishknight,
j-hui,
jckarter,
rintaro,
susmonteiro and
zoecarver
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please test Linux |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To hack around the ConstructorDecl behavior, add a withCovariantResultType() that instead sticks a DynamicSelfType in the right place, and only if its a class constructor.