Fix order of building mimalloc with -IncludeNoAsserts
#83867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Aug 22, 2025
|
@swift-ci please smoke test |
mhegazy
force-pushed
the
mimalloc-patch-fix
branch
from
167b415 to
effe6d6
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
compnerd
added
Windows
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke this in my previous PR.
Build-mimallocdoes two things, it builds mimalloc, and patches binaries. since we have two toolchains now we need to make sure both happen for both assert and noassert toolchain outputs when building with-IncludeNoAsserts.In this change:
Build-mimallocinto two functionsPatch-mimallocafter the noasserts toolchain was built to enable successful patching.