[Caching] Do not infer default on disk cas path when parsing options #83878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-134363755
branch
from
4d821e0 to
2714cc0
Compare
|
@swift-ci please smoke test |
Currently, swift-frontend will always try to infer a default CASPath if no `-cas-path` is passed. The function `getDefaultOnDiskCASPath` called to infer the default path can fatal error in some environment where no caching directory and home directory, no matter if caching is used or not. Remove the inferred path during parsing since that is not strictly necessary. If caching is enabled and no CASPath is passed, error can be issued during CAS construction time. rdar://158899187
cachemeifyoucan
force-pushed
the
eng/PR-134363755
branch
from
2714cc0 to
492f5ab
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows platform |
benlangmuir
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, swift-frontend will always try to infer a default CASPath if no
-cas-pathis passed. The functiongetDefaultOnDiskCASPathcalled to infer the default path can fatal error in some environment where no caching directory and home directory, no matter if caching is used or not.Remove the inferred path during parsing since that is not strictly necessary. If caching is enabled and no CASPath is passed, there will be error during CAS construction time.
rdar://158899187