[SILGen] Remove and replace ad-hoc assign_by_wrapper instruction
#83886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrapper variables
janbaig
requested review from
eeckstein,
hborla,
jckarter,
kavon,
rjmccall,
slavapestov and
xymus
as code owners
xedin
reviewed
Aug 25, 2025
xedin
reviewed
Aug 25, 2025
xedin
reviewed
Aug 25, 2025
xedin
reviewed
Aug 25, 2025
xedin
reviewed
Aug 25, 2025
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
reviewed
Aug 29, 2025
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is part of the ongoing effort to reimplement property wrappers in terms of init accessors, reducing their reliance on special-case infrastructure in SILGen.
As a step toward this, the ad-hoc
assign_by_wrapperinstruction, specific to property wrappers, has been removed and replaced with the more generalassign_or_init, which was originally introduced to support init accessors. This unifies wrapper initialization with existing compiler features instead of maintaining a separate SILGen instruction.SILGen now synthesizes an init accessor thunk that performs the wrapper initialization (
self._x = Wrapper(initialValue:)) and passes it intoassign_or_init. This ensures property wrapper initialization is expressed through the same pathway as other init accessor cases.