Skip to content

Conversation

slavapestov
Copy link
Contributor

This just introduces function colors everywhere. The main risk is that this may change runtime behavior in some subtle way, or interact badly with how we do performance counters.

@slavapestov slavapestov requested a review from eeckstein as a code owner August 23, 2025 18:37
@slavapestov slavapestov force-pushed the async-benchmark branch 2 times, most recently from 82dfaae to c1c499b Compare August 23, 2025 18:47
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, thanks Slava!

@slavapestov
Copy link
Contributor Author

@swift-ci Please benchmark

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please benchmark

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov enabled auto-merge August 28, 2025 22:06
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test macOS

@slavapestov slavapestov merged commit 89bc9df into swiftlang:main Aug 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants