Skip to content

Speed up -isEqual:/isEqualToString: #83894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 26, 2025
Merged

Speed up -isEqual:/isEqualToString: #83894

merged 7 commits into from
Aug 26, 2025

Conversation

Catfish-Man
Copy link
Contributor

@Catfish-Man Catfish-Man commented Aug 24, 2025 •
edited
Loading

Fixes rdar://159058877

@Catfish-Man Catfish-Man requested a review from a team as a code owner August 24, 2025 18:00
@Catfish-Man Catfish-Man self-assigned this Aug 24, 2025
@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please Apple Silicon benchmark

@Catfish-Man Catfish-Man changed the title Use -isNSString__ instead of shimming through CFGetTypeID, since it's faster Speed up -isEqual:/isEqualToString: Aug 24, 2025
@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please Apple Silicon benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please Apple Silicon benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please Apple Silicon benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please Apple Silicon benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please Apple Silicon benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man Catfish-Man enabled auto-merge (squash) August 25, 2025 16:18
@Catfish-Man
Copy link
Contributor Author 

IMPROVEMENT                              OLD       NEW      DELTA     RATIO    
09:46:59  ObjectiveCBridgeStringIsEqual2           100.857   57.895   -42.6%    **1.74x**
09:46:59  ObjectiveCBridgeStringIsEqualAllSwift    26.173    18.844   -28.0%    **1.39x**
09:46:59  ObjectiveCBridgeStringIsEqual            109.529   95.143   -13.1%    **1.15x**

@Catfish-Man Catfish-Man merged commit 0038b92 into swiftlang:main Aug 26, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmschonfeld jmschonfeld jmschonfeld approved these changes

Assignees

@Catfish-Man Catfish-Man

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Catfish-Man @jmschonfeld