[IRGen] Look for a specialized deinit when forming a call in IRGen #83906
Conversation
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
When outlining a destroy operation, we form direct calls to the deinit of noncopyable types. For generic types, this was always calling into unspecialized generics, which is... deeply unfortunate. Look for a specialized deinit and call that instead. This eliminates a compiler assertion in Embedded Swift, and should improve performance with noncopyable generics elsewhere. Fixes rdar://159054138 and swiftlang#72627 / rdar://157131184.
DougGregor
force-pushed
the
specialized-deinit-in-destroy-outlining
branch
from
2a3a14f to
beeb45d
Compare
|
@swift-ci please smoke test |
| auto substitutions = ty->getContextSubstitutionMap(); | ||
| if (!substitutions.empty() && | ||
| !substitutions.getRecursiveProperties().hasArchetype()) { | ||
| Mangle::GenericSpecializationMangler mangler( |
There was a problem hiding this comment.
This is kind of gross, is there a better way where we actually store the specializations in a table somewhere?
There was a problem hiding this comment.
It is totally gross, I agree. A better answer I was considering is to allow SILMoveOnlyDeinit to carry a substitution map, and make it possible to look up (nominal type, substitution map) pairs in the module + serialized module. We would specialize the SILMoveOnlyDeinit when we see a nominal type specialization that has a deinit.
There was a problem hiding this comment.
I'm going to start with my hack to unblock some stuff
|
This approach is completely wrong. It just works by coincidence for this specific test case. The correct fix is: #83913 |
3 participants
When outlining a destroy operation, we form direct calls to the deinit of noncopyable types. For generic types, this was always calling into unspecialized generics, which is... deeply unfortunate.
Look for a specialized deinit and call that instead. This eliminates a compiler assertion in Embedded Swift, and should improve performance with noncopyable generics elsewhere.
Fixes rdar://159054138 and #72627 / rdar://157131184.