Add LLDB and swift-reflection-dump support for WebAssembly #83923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
mikeash
approved these changes
Aug 26, 2025
adrian-prantl
force-pushed
the
wasm-reflection
branch
from
978a8ac to
89d8a40
Compare
JDevlieghere
approved these changes
Aug 26, 2025
adrian-prantl
force-pushed
the
wasm-reflection
branch
2 times, most recently
from
f247e52 to
69a2f4b
Compare
kateinoigakukun
approved these changes
Aug 26, 2025
MaxDesiatov
reviewed
Aug 27, 2025
| }; | ||
|
|
||
| /// Decode 32-bit ULEB constants. | ||
| auto decodeULEB32 = [&](uint32_t &val) -> bool { |
There was a problem hiding this comment.
Unfortunate that we have to reimplement these for the umpteenth time. Is there no code object format parsing code in LLVM to reuse here?
MaxDesiatov
approved these changes
Aug 27, 2025
It has, but the problem here is twofold:
|
|
@swift-ci test |
This patch adds parsing and extracting of the Swift reflection metadata data segments from within the WebAssembly DATA section and tests it using swift-reflection-dump. This is needed to allow LLDB to acces Swift reflection metadata when attached to WebAssembly processes. rdar://159217213
adrian-prantl
force-pushed
the
wasm-reflection
branch
from
69a2f4b to
75bee89
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds parsing and extracting of the Swift reflection metadata data segments from within the WebAssembly DATA section and tests it using swift-reflection-dump. This is needed to allow LLDB to acces Swift reflection metadata when attached to WebAssembly processes.
rdar://159217213