[Sema] Avoid marking TypeRepr invalid with SilenceErrors
#83974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pattern resolution currently invokes type resolution with this flag since it's trying to see if it can treat a given expression as a TypeRepr for e.g an enum pattern. Make sure we don't `setInvalid` on such TypeRepr nodes since that will avoid diagnosing in cases where the node also then gets treated as a TypeRepr for an ExprPattern, where we actually want the diagnostic emitted.
If no other error has been emitted, make sure we emit a fallback diagnostic rather than crashing in the ASTVerifier or SILGen.
hamishknight
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
AnthonyLatsis
approved these changes
Aug 28, 2025
xedin
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pattern resolution currently invokes type resolution with this flag since it's trying to see if it can treat a given expression as a TypeRepr for e.g an enum pattern. Make sure we don't
setInvalidon such TypeRepr nodes since that will avoid diagnosing in cases where the node also then gets treated as a TypeRepr for an ExprPattern, where we actually want the diagnostic emitted.Also ensure that
IgnoreInvalidASTNodeemits a fallback diagnostic if no other error has been emitted to ensure that any future similar cases don't end up crashing the compiler in the ASTVerifier or SILGen.