Add __arm__ to Float16Support.cpp for arm 32-bit architectures #83979
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is required for some missing symbols for static linking and tests.
|
@swift-ci smoke test |
stephentyrone
approved these changes
Aug 28, 2025
MaxDesiatov
added
arm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only patch required to cross-compile Swift for armv6 and armv7 that is used here:
https://github.com/swift-embedded-linux/armhf-debian/blob/main/patches/0002-Add-arm-to-float16support-for-missing-symbol.patch
@MaxDesiatov I feel like this could be separate from my cross-compilation product, which will require/include this as well. I want to make sure this change will not negatively impact anything else.