[Completion] Avoid type-checking parent closure for unattached node #83982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should have already type-checked a parent closure, and we wouldn't be able to correctly locate the node anyway since it's not actually part of the AST. While here, also walk up to the parent-most closure instead of recursing to avoid unnecessary stack frames for nested closures.
hamishknight
requested review from
bnbarham,
hborla,
rintaro,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
bnbarham
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have already type-checked a parent closure, and we wouldn't be able to correctly locate the node anyway since it's not actually part of the AST. While here, also walk up to the parent-most closure instead of recursing to avoid unnecessary stack frames for nested closures.