Skip to content

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Aug 28, 2025

We need the init?(JobPriority) constructor to be StdlibDeploymentTarget 5.9
so the compiler will not complain when we reference it
from ExecutorJob.createTrampoline when building the standard library
without strict availability.

Addresses rdar://159397287

We need the `init?(JobPriority)` constructor to be
`StdlibDeploymentTarget 5.9`
so the compiler will not complain when we reference it
 from `ExecutorJob.createTrampoline` when building the standard library
without strict availability.

Addresses rdar://159397287
@edymtt edymtt requested a review from al45tair August 28, 2025 22:40
@edymtt edymtt requested a review from ktoso as a code owner August 28, 2025 22:40
@edymtt
Copy link
Contributor Author

edymtt commented Aug 28, 2025

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Aug 28, 2025

@swift-ci please build toolchain

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thank you.

@al45tair
Copy link
Contributor

al45tair commented Aug 29, 2025

This test failed on macOS:

lldb-api :: functionalities/tsan/swift-access-race/TestTsanSwiftAccessRace.py

I don't believe that's related in any way to this change.

@al45tair
Copy link
Contributor

@swift-ci Please test macOS platform

@edymtt edymtt enabled auto-merge August 29, 2025 13:38
@edymtt
Copy link
Contributor Author

edymtt commented Aug 29, 2025

@swift-ci Please smoke test macOS

@edymtt edymtt merged commit 5464129 into swiftlang:main Aug 29, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants