[CS] Fix an overly strict assert #83992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`matchExistentialTypes` can handle existential metatypes, fix the assert to handle that.
|
@swift-ci please smoke test |
xedin
approved these changes
Aug 28, 2025
slavapestov
reviewed
Aug 29, 2025
| kind != ConstraintKind::NonisolatedConformsTo && | ||
| kind != ConstraintKind::TransitivelyConformsTo) || | ||
| second->isExistentialType()); | ||
| second->isAnyExistentialType()); |
There was a problem hiding this comment.
Should we unwrap the metatype before we generate the constraint though, in the caller?
There was a problem hiding this comment.
I don't think we can since we rely on matchExistentialTypes to iteratively match each level of metatype, i.e if you have $T0 <> P.Type, we need to form an unsolved constraint with P.Type since we wouldn't want it to succeed if $T0 ends up being simply S rather than S.Type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matchExistentialTypescan handle existential metatypes, fix the assert to handle that.