Skip to content

[CS] Strengthen check for completion in CSApply #84005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2025
Merged

[CS] Strengthen check for completion in CSApply #84005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Sema/CSApply.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ namespace {
void addLocalDeclToTypeCheck(Decl *D) {
// If we're doing code completion, avoid doing any further type-checking,
// that should instead be handled by TypeCheckASTNodeAtLocRequest.
if (ctx.CompletionCallback)
if (ctx.SourceMgr.hasIDEInspectionTargetBuffer())
return;

LocalDeclsToTypeCheck.push_back(D);
Expand All @@ -461,7 +461,7 @@ namespace {
void addMacroToExpand(MacroExpansionExpr *E) {
// If we're doing code completion, avoid doing any further type-checking,
// that should instead be handled by TypeCheckASTNodeAtLocRequest.
if (ctx.CompletionCallback)
if (ctx.SourceMgr.hasIDEInspectionTargetBuffer())
return;

MacrosToExpand.push_back(E);
Expand Down
2 changes: 1 addition & 1 deletion ...-test/IDE/crashers/ce6e7a44344828a0.swift → ...IDE/crashers_fixed/ce6e7a44344828a0.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// {"kind":"complete","signature":"(anonymous namespace)::ConstraintWalker::walkToExprPost(swift::Expr*)"}
// RUN: not --crash %target-swift-ide-test -code-completion -batch-code-completion -skip-filecheck -code-completion-diagnostics -source-filename %s
// RUN: %target-swift-ide-test -code-completion -batch-code-completion -skip-filecheck -code-completion-diagnostics -source-filename %s
enum a }
{
var b: a func c { switch b {
Expand Down
2 changes: 1 addition & 1 deletion ...-test/IDE/crashers/e7327cfd8bafcd86.swift → ...IDE/crashers_fixed/e7327cfd8bafcd86.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// {"kind":"complete","original":"bc7ab9d8","signature":"swift::constraints::ConstraintSystem::getTypeOfReference(swift::ValueDecl*, swift::FunctionRefInfo, swift::constraints::ConstraintLocatorBuilder, swift::DeclContext*, swift::constraints::PreparedOverloadBuilder*)","signatureAssert":"Assertion failed: (func->isOperator() && \"Lookup should only find operators\"), function getTypeOfReference"}
// RUN: not --crash %target-swift-ide-test -code-completion -batch-code-completion -skip-filecheck -code-completion-diagnostics -source-filename %s
// RUN: %target-swift-ide-test -code-completion -batch-code-completion -skip-filecheck -code-completion-diagnostics -source-filename %s
{
func a(query: String) {
{
Expand Down