[CSOptimizer] Don't match nil to _OptionalNilComparisonType
#84012
+18
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility debug |
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
|
@swift-ci please smoke test macOS platform |
This type is only intended for pattern matching against `nil` and the solver shouldn't early attempt to infer this type for `nil` for arguments of `==` and `!=` operators it should instead be inferred from other argument or result. Resolves: rdar://158063151
xedin
force-pushed
the
rdar-158063151
branch
from
97d4f7b to
df962a8
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type is only intended for pattern matching against
niland the solver shouldn't early attempt to infer this type fornilfor arguments of==and!=operators it should instead be inferred from other argument or result.Resolves: rdar://158063151