Include remarks in SourceKit diagnostics responses #84031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
bnbarham
reviewed
Aug 31, 2025
| // CHECK-NEXT: { | ||
| // CHECK-NEXT: key.line: 2, | ||
| // CHECK-NEXT: key.column: 24, | ||
| // CHECK-NEXT: key.filepath: "SOURCE_DIR/test/SourceKit/Diagnostics/remarks.swift", |
There was a problem hiding this comment.
Need both / and \ for Windows
There was a problem hiding this comment.
I think that %/s might allow us to get away in this case to avoid the regexes.
owenv
force-pushed
the
owenv/sourcekit-remarks
branch
from
3a3dbfa to
429c1be
Compare
|
@swift-ci smoke test |
owenv
force-pushed
the
owenv/sourcekit-remarks
branch
from
429c1be to
593346a
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remarks are increasingly used as a way of allowing users to additional opt-in information about a compile, and it makes sense to make this information available to clients of SourceKit as well.