[CS] Avoid increasing score for unbound outer type vars for completion #84036
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please SourceKit stress test |
When doing code completion it's entirely expected we'll end up with ambiguities in the body of a closure if we're completing e.g `someOverloadedFn(#^CC^#)`. As such we don't want to penalize the solution for unbound type variables outside of the body since that will prevent us from being able to eagerly prune e.g disfavored overloads in the outer scope. This gives up to a 7% perf win in the stress tester.
hamishknight
force-pushed
the
pothole
branch
from
61da900 to
ebad04f
Compare
hamishknight
changed the title
|
@swift-ci please smoke test |
hamishknight
requested review from
bnbarham,
hborla,
rintaro and
xedin
as code owners
This was referenced Sep 1, 2025
|
@hamishknight one more thing we can do to improve ranking is to checking whether arguments had any holes or fixes associated with them before ranking overloads, I don’t think it makes sense to rank choices that got fixed since the assumption in the ranking is that everything was matched correctly. |
|
@xedin Assuming I understand you correctly, I think we should already handle that case, we check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing code completion it's entirely expected we'll end up with ambiguities in the body of a closure if we're completing e.g
someOverloadedFn(#^CC^#). As such we don't want to penalize the solution for unbound type variables outside of the body since that will prevent us from being able to eagerly prune e.g disfavored overloads in the outer scope. This gives up to a 7% perf win in the stress tester.