Skip to content

[CS] Add debug message when hitting too complex limit #84042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

[CS] Add debug message when hitting too complex limit #84042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions include/swift/Sema/ConstraintSystem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5671,13 +5671,22 @@ class ConstraintSystem {
if (CancellationFlag && CancellationFlag->load(std::memory_order_relaxed))
return true;

auto markTooComplex = [&](SourceRange range, StringRef reason) {
if (isDebugMode()) {
if (solverState)
llvm::errs().indent(solverState->getCurrentIndent());
llvm::errs() << "(too complex: " << reason << ")\n";
}
isAlreadyTooComplex = {true, range};
return true;
};

auto used = getASTContext().getSolverMemory() + solutionMemory;
MaxMemory = std::max(used, MaxMemory);
auto threshold = getASTContext().TypeCheckerOpts.SolverMemoryThreshold;
if (MaxMemory > threshold) {
// No particular location for OoM problems.
isAlreadyTooComplex.first = true;
return true;
return markTooComplex(SourceRange(), "exceeded memory limit");
}

if (Timer && Timer->isExpired()) {
Expand All @@ -5686,23 +5695,18 @@ class ConstraintSystem {
// emitting an error.
Timer->disableWarning();

isAlreadyTooComplex = {true, Timer->getAffectedRange()};
return true;
return markTooComplex(Timer->getAffectedRange(), "exceeded time limit");
}

auto &opts = getASTContext().TypeCheckerOpts;

// Bail out once we've looked at a really large number of choices.
if (opts.SolverScopeThreshold && NumSolverScopes > opts.SolverScopeThreshold) {
isAlreadyTooComplex.first = true;
return true;
}
if (opts.SolverScopeThreshold && NumSolverScopes > opts.SolverScopeThreshold)
return markTooComplex(SourceRange(), "exceeded scope limit");

// Bail out once we've taken a really large number of steps.
if (opts.SolverTrailThreshold && NumTrailSteps > opts.SolverTrailThreshold) {
isAlreadyTooComplex.first = true;
return true;
}
if (opts.SolverTrailThreshold && NumTrailSteps > opts.SolverTrailThreshold)
return markTooComplex(SourceRange(), "exceeded trail limit");

return false;
}
Expand Down