CMake: Runtime: Extract runtime version number #84063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please test |
compnerd
approved these changes
Sep 2, 2025
edymtt
approved these changes
Sep 2, 2025
|
Fixes: #83936 |
|
@swift-ci please smoke test macOS |
This is failing in a timeout while building LLVM. We're not to the point of building Swift so I think that this is unrelated to the PR. |
This extracts the version number computation out into a separate module to be shared between the runtimes. Setting `SWIFT_RUNTIME_VERSION` allows external build orchestration tools to override the version number specified in source if necessary, while centralizing the location of the default version number across the runtime libraries.
etcwilde
force-pushed
the
ewilde/runtime-version-number
branch
from
5e172e2 to
0bebd9d
Compare
|
@swift-ci please smoke test |
shahmishal
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the version number computation out into a separate module to be shared between the runtimes.
Setting
SWIFT_RUNTIME_VERSIONallows external build orchestration tools to override the version number specified in source if necessary, while centralizing the location of the default version number across the runtime libraries.