AST: Fix runtime unavailability for universally unavailable decls #84070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In anticipation of needing to compute runtime unavailability to determine whether declarations should be printed in swiftinterfaces, factor out the code that computes runtime unavailability into a shared utility based on `DeclAvailabilityConstraints`. NFC.
|
@swift-ci please test |
The logic that computes whether a decl is unavailable at runtime was allowing `@available` attributes for specific availability domains override `@available(*, unavailable)`. Universally unavailable decls are always unavailable, regardless of their other `@available` attributes.
tshortli
force-pushed
the
universally-unavailable-at-runtime
branch
from
521a3bb to
e390cce
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic that computes whether a decl is unavailable at runtime was allowing
@availableattributes for specific availability domains override@available(*, unavailable). Universally unavailable decls are always unavailable, regardless of their other@availableattributes.