[6.2][cxx-interop] Do not consider function types fragile #84073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanationion: Function pointer types wee always considered fragile in C++ mode, this manifested as a regression when interfacing with glibc. Issues: rdar://159184118 Original PRs: swiftlang#84040 Risk: Low, this only removes a spurious error for library evolution. Testing: Added a compiler test. Reviewers: @egorzhdan
Xazax-hun
added
c++ interop
|
@swift-ci please test |
egorzhdan
approved these changes
Sep 3, 2025
|
@swift-ci please test Windows |
DougGregor
approved these changes
Sep 3, 2025
|
@Xazax-hun, should we submit this for the 6.2.0 and 6.2.1 branches too, so it doesn't regress with the upcoming 6.2 release? |
|
I am afraid the ship for |
|
Opened PR: #84164 |
@DougGregor, what do you think: can we get this into 6.2.0 also, so it doesn't regress with that upcoming release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanationion: Function pointer types wee always considered fragile in C++ mode, this manifested as a regression when interfacing with glibc.
Issues: rdar://159184118
Original PRs: #84040
Risk: Low, this only removes a spurious error for library evolution.
Testing: Added a compiler test.
Reviewers: @egorzhdan