[6.2 🍒][Dependency Scanning] Give each scanner worker a unique Diagnostic Engine #84089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
…ic Engine Otherwise, when multiple workers encounter a diagnostic simultaneously we can encounter races which lead to corrupted diagnostic data or crashes Resolves rdar://159598539
artemcm
force-pushed
the
62_DepScanWorkersNoShareDiagEngine
branch
from
cb278e2 to
0fa722f
Compare
|
@swift-ci test |
nkcsgexi
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #84064
Explanation: When multiple workers encounter a diagnostic simultaneously we can encounter races which lead to corrupted diagnostic data or crashes due to the workers sharing a common
DiagnosticEngine. This change gives each worker a unique diagnostic engine, with all workers' engines sharing a thread-safe diagnostic collecting consumer.Scope: Builds with explicitly-built modules where the scanning action encounters concurrent error diagnostics while scanning modules or instantiating Clang scanners.
Risk: Low. This change removes shared mutable state and is not expected to have adverse effects on the scanner functionality.
Problem: rdar://159598539
Reviewed By: @cachemeifyoucan
Original PR: [Dependency Scanning] Give each scanner worker a unique Diagnostic Engine #84064