Optimizer: replace explicit_copy_value and explicit_copy_addr with their non-explicit counterparts
#84101
+126
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
aidan-hall,
atrick,
kavon,
meg-gupta and
nate-chandler
|
@swift-ci smoke test |
meg-gupta
reviewed
Sep 4, 2025
SwiftCompilerSources/Sources/Optimizer/InstructionSimplification/SimplifyExplicitCopy.swift
Show resolved
Hide resolved
|
LGTM otherwise |
eeckstein
force-pushed
the
simplify-explicit-copy
branch
from
eeba50e to
e7f8691
Compare
|
@swift-ci smoke test |
…h their non-explicit counterparts The `explicit_copy_value` and `explicit_copy_addr` instructions are only used for non-copyable diagnostics in the mandatory pipeline. After that we can replace them by their non-explicit counterparts so that optimizations (which only know of `copy_value` and `copy_addr`) can do their work. rdar://159039552
eeckstein
force-pushed
the
simplify-explicit-copy
branch
from
e7f8691 to
844217d
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
explicit_copy_valueandexplicit_copy_addrinstructions are only used for non-copyable diagnostics in the mandatory pipeline. After that we can replace them by their non-explicit counterparts so that optimizations (which only know ofcopy_valueandcopy_addr) can do their work.rdar://159039552