🍒 [cxx-interop] Prevent crash when importing a std::optional of nonescapable #84104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susmonteiro
added
c++ interop
|
@swift-ci please test |
Xazax-hun
approved these changes
Sep 4, 2025
susmonteiro
force-pushed
the
6.2-nonescapable-std-optional
branch
from
7eadbd4 to
a02374a
Compare
…nescapable When we tried to create a std::optional of a nonescapable type in Swift, the compiler would run into an assertion failure. This is because std::optional has an anonymous union where one of its members would be of this nonescapable type. Turns out that we were not handling anonymous unions with nonescapable members correctly. Fields of anonymous unions are injected to the parent as IndirectFieldDecl, so we need to handle these indirect fields the same way we handle "normal" fields. rdar://156704699
susmonteiro
force-pushed
the
6.2-nonescapable-std-optional
branch
from
a02374a to
29e5549
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::optionalof nonescapable type.