-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Debug prefix macro search paths #84112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the macro path in swift module is only used for debugging purpose. Remapping with -debug-prefix-map
sounds reasonable to me.
However in long term, we should rethink how all the remapping options are done because the interaction between multiple remapping options are going to be interesting.
@swift-ci Please smoke test |
I was also considering disabling this serialization if this is an explicit module build, but couldn't confirm that we didn't need the macro search path logic in the debugger in that case. If we already have the modules built, would we need the macro lookup logic still? |
@adrian-prantl probably knows better. The plugin search paths are definitely used to create expression evaluator even for explicit module build, but explicit module build on latest swift should used resolved macro option only. That probably means you can use macro in lldb expression evaluator so we still want them to be there. |
c9fa7f0
to
e735a24
Compare
@swift-ci Please smoke test |
Macro search paths are generally absolute paths which will cause non-deterministic output for build systems that build remotely. When the -prefix-serialized-debugging-options flag is set remap the macro search paths as well as the other debug paths.
e735a24
to
7296b28
Compare
@swift-ci Please smoke test |
@swift-ci please test |
Trigger full run, since this is debugging related. |
Macro search paths are generally absolute paths which will cause non-deterministic output for build systems that build remotely. When the -prefix-serialized-debugging-options flag is set remap the macro search paths as well as the other debug paths.