[6.2] Build CMake on macOS if one is not preinstalled #84123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We build CMake on all platforms (except Darwin for an unknown reason) if CMake is not preinstalled. Since CMake 4.0 regresses certain build configurations, there's currently no way to build on Darwin without installing an older CMake version 3.x manually. This can be simplified if we build a pinned version of CMake consistently on all platforms. Addresses rdar://159939866 (cherry picked from commit 7db6c5d)
|
@swift-ci please test |
MaxDesiatov
approved these changes
Sep 5, 2025
|
@swift-ci please test macOS |
|
@swift-ci please test macOS Apple Silicon |
etcwilde
approved these changes
Sep 5, 2025
shahmishal
approved these changes
Sep 5, 2025
|
@swift-ci test |
|
why not ship cmake as part of the xcode clt? (while we're at it, why not also natively support cmake in xcode?) |
Xcode is an Apple commercial product, not controlled by the Swift open-source project. Suggestions for Xcode improvements should be filed via Apple's feedback assistant. |
|
oh okay, but i can see y'all work at apple on your profiles? can't you or someone else here just talk with your fellow xcode teammates to see if they can/want to both start shipping and supporting cmake in xcode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes a gap in the setup of the build -- while most of the macOS configurations install CMake before hand, this would avoid a hard failure when we forget to do so.
Builds on macOS that do not provide a prebuilt CMake before hand.
Build CMake on macOS if one is not preinstalled #81161
Low -- this only affects macOS configurations that do not have CMake already in the path, which are a small number of all configurations (since at desk we give clear instructions about installing prerequisites, and on CI we install those automatically).
Ensured at desk that on a macOS system with no CMake or ninja in the search path build-script is able to build those and get to the build of LLVM.