Skip to content

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Sep 5, 2025

Also mark them as not executable, since they don't call %target-run.

This is needed back deployment configurations where StringProcessing is
not supported.

Addresses rdar://159635486

@edymtt
Copy link
Contributor Author

edymtt commented Sep 5, 2025

@swift-ci please test

@edymtt edymtt requested a review from bnbarham September 5, 2025 16:11
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Also mark them as not executable, since they don't call `%target-run`.

This is needed back deployment configurations where StringProcessing is
not supported.

Addresses rdar://159635486
@edymtt edymtt force-pushed the edymtt/require-string-processing-for-macros-executable-tests branch from 3768bd8 to 624987f Compare September 5, 2025 17:34
@edymtt edymtt changed the title Require build of StringProcessing to run Macros executable tests. Require build of StringProcessing for some Macros tests Sep 5, 2025
@edymtt
Copy link
Contributor Author

edymtt commented Sep 5, 2025

@swift-ci please test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely clear why string processing is needed in these and not others, but the removal of executable_test makes sense 👍

@edymtt
Copy link
Contributor Author

edymtt commented Sep 5, 2025

@swift-ci please test Windows

@edymtt edymtt enabled auto-merge (squash) September 5, 2025 18:09
@edymtt
Copy link
Contributor Author

edymtt commented Sep 5, 2025

@swift-ci please test macOS

@edymtt edymtt merged commit 89c3f47 into swiftlang:main Sep 6, 2025
5 checks passed
@edymtt edymtt deleted the edymtt/require-string-processing-for-macros-executable-tests branch September 9, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants