ASTGen: Fix disable implicit string processing import #84129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
requested review from
CodaFi,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
compnerd
approved these changes
Sep 5, 2025
The flag is a frontend flag not a driver flag. Fixing how that is passed.
etcwilde
force-pushed
the
ewilde/fix-ASTGen-string-processing-import
branch
from
29bcd3c to
6b92d1d
Compare
|
@swift-ci please smoke test |
compnerd
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ driver doesn't see this flag as a valid driver flag, only as a frontend flag resulting in an error message on bootstrap jobs.
https://ci.swift.org/job/swift-bootstrap-ubuntu-24_04-x86_64/425/