[CS] NFC: Remove CTP_ForEachStmt
#84142
Merged
+3
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
xedin and
slavapestov
as code owners
|
@swift-ci please smoke test |
slavapestov
approved these changes
Sep 6, 2025
xedin
approved these changes
Sep 6, 2025
|
@hamishknight can some of the typechecker and constraint options be removed too since fallback typecheck is gone? |
|
FWIW I'm also hoping we can re-land #36028, we need to make some fixes first to eliminate a couple of cases where we're double type-checking and doing CSApply with holes though |
|
Yeah, I know that at least one option what there to support fallback type-checking, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now unused.